netdev - Re: [PATCH iwl-next v4] ice: Remove and readd netdev during devlink reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eab37717-8899-4dcf-b97a-2214b4387278@intel.com>
Date: Tue, 30 Jan 2024 13:32:58 +0100
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<przemyslaw.kitszel@...el.com>, <vadim.fedorenko@...ux.dev>,
	<paul.m.stillwell.jr@...el.com>, <bcreeley@....com>
Subject: Re: [PATCH iwl-next v4] ice: Remove and readd netdev during devlink
 reload



On 30.01.2024 12:36, Jiri Pirko wrote:
> Tue, Jan 30, 2024 at 11:31:01AM CET, wojciech.drewek@...el.com wrote:
>> Recent changes to the devlink reload (commit 9b2348e2d6c9
>> ("devlink: warn about existing entities during reload-reinit"))
>> force the drivers to destroy devlink ports during reinit.
>> Adjust ice driver to this requirement, unregister netdvice, destroy
> 
> s/netdvice/netdevice/
> 
>> devlink port. ice_init_eth() was removed and all the common code
>> between probe and reload was moved to ice_load().
>>
>> During devlink reload we can't take devl_lock (it's already taken)
>> and in ice_probe() we have to lock it. Use devl_* variant of the API
>> which does not acquire and release devl_lock. Guard ice_load()
>> with devl_lock only in case of probe.
>>
>> Introduce ice_debugfs_pf_deinit() in order to release PF's
>> debugfs entries. Move ice_debugfs_exit() call to ice_module_exit().
> 
> Sounds something like 3 patches to me :)

Hmmm, yea I think I can extract debugfs part but the rest feels
logically cohesive to me so I'll keep it together.

> 
> 
>>
>> Suggested-by: Jiri Pirko <jiri@...dia.com>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
>> Reviewed-by: Simon Horman <horms@...nel.org>
>> Reviewed-by: Brett Creeley <brett.creeley@....com>
>> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
>> ---
>> v2: empty init removed in ice_devlink_reinit_up
>> v3: refactor locking pattern as Brett suggested
>> v4: fix wrong function name in commit message
>> ---
>> drivers/net/ethernet/intel/ice/ice.h         |   3 +
>> drivers/net/ethernet/intel/ice/ice_debugfs.c |  10 +
>> drivers/net/ethernet/intel/ice/ice_devlink.c |  68 ++++++-
>> drivers/net/ethernet/intel/ice/ice_fwlog.c   |   2 +
>> drivers/net/ethernet/intel/ice/ice_main.c    | 189 ++++++-------------
> 
> Yeah. Would be better to split. But up to you.