[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240130131334.GJ351311@kernel.org>
Date: Tue, 30 Jan 2024 13:13:34 +0000
From: Simon Horman <horms@...nel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, anthony.l.nguyen@...el.com,
netdev@...r.kernel.org, Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH iwl-next v4 1/3] ixgbe: Convert ret val type from s32 to
int
On Fri, Jan 26, 2024 at 02:05:01PM +0100, Jedrzej Jagielski wrote:
> Currently big amount of the functions returning standard error codes
> are of type s32. Convert them to regular ints as typdefs here are not
> necessary to return standard error codes.
>
> Fix incorrect args alignment in touched functions.
>
> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Thanks Jedrzej,
this looks good to me.
With the nit below resolved, please feel free to add:
Reviewed-by: Simon Horman <horms@...nel.org>
...
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c
...
> @@ -115,7 +110,7 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw,
> }
>
> /**
> - * ixgbe_dcb_config_tx_data_arbiter_82598 - Config Tx data arbiter
> + * xgbe_dcb_config_tx_data_arbiter_82598 - Config Tx data arbiter
nit: ixgbe_dcb_config_tx_data_arbiter_82598
> * @hw: pointer to hardware structure
> * @refill: refill credits index by traffic class
> * @max: max credits index by traffic class
> @@ -124,11 +119,8 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw,
> *
> * Configure Tx Data Arbiter and credits for each traffic class.
> */
> -s32 ixgbe_dcb_config_tx_data_arbiter_82598(struct ixgbe_hw *hw,
> - u16 *refill,
> - u16 *max,
> - u8 *bwg_id,
> - u8 *prio_type)
> +int ixgbe_dcb_config_tx_data_arbiter_82598(struct ixgbe_hw *hw, u16 *refill,
> + u16 *max, u8 *bwg_id, u8 *prio_type)
> {
> u32 reg;
> u8 i;
...
Powered by blists - more mailing lists