netdev - RE: [EXT] Re: [PATCH net v2] octeontx2-af: Initialize bitmap arrays.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <MWHPR1801MB191843DEDB02E33820676F6AD37D2@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date: Tue, 30 Jan 2024 02:40:47 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Brett Creeley <bcreeley@....com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Hariprasad
 Kelam <hkelam@...vell.com>,
        Suman Ghosh <sumang@...vell.com>
Subject: RE: [EXT] Re: [PATCH net v2] octeontx2-af: Initialize bitmap arrays.

> From: Brett Creeley <bcreeley@....com>
> Subject: [EXT] Re: [PATCH net v2] octeontx2-af: Initialize bitmap arrays.
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > @@ -184,11 +184,11 @@ struct npc_mcam {
> >          unsigned long   *bmap_reverse;  /* Reverse bitmap, bmap_entries =>
> 0 */
> >          u16     bmap_entries;   /* Number of unreserved MCAM entries */
> >          u16     bmap_fcnt;      /* MCAM entries free count */
> > -       u16     *entry2pfvf_map;
> > -       u16     *entry2cntr_map;
> > -       u16     *cntr2pfvf_map;
> > -       u16     *cntr_refcnt;
> > -       u16     *entry2target_pffunc;
> > +       unsigned long   *entry2pfvf_map;
> > +       unsigned long   *entry2cntr_map;
> > +       unsigned long   *cntr2pfvf_map;
> > +       unsigned long   *cntr_refcnt;
> > +       unsigned long   *entry2target_pffunc;
> 
> I'm not sure you want all of these at bitmaps? It was recommended to use
> bitmap_zalloc, but that was specifically for the bitmaps.
Sorry, I didn't get you. 
Bitmap_zalloc() returns unsigned long * 
"unsigned long *bitmap_zalloc(unsigned int nbits, gfp_t flags)"