netdev - Re: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac failed when running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 17:51:04 -0500
From: Sasha Levin <sashal@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	duanqiangwen <duanqiangwen@...-swift.com>, jiawenwu@...stnetic.com,
	mengyuanlou@...-swift.com, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, andrew@...n.ch, bhelgaas@...gle.com,
	maciej.fijalkowski@...el.com, horms@...nel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac
 failed when running

On Tue, Jan 16, 2024 at 05:39:55PM -0800, Jakub Kicinski wrote:
>On Tue, 16 Jan 2024 14:39:16 -0500 Sasha Levin wrote:
>> in some bonding mode, service need to change mac when
>> netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
>> priv_flag to support it.
>
>Not really a fix, more of a feature ennoblement.
>Let's drop it, we don't know what it may uncover.
>
>We should probably start complaining when people use
>the word "fix" for non-fixes :(

I'll drop it :)

-- 
Thanks,
Sasha