[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240130164706.6eb6a9b3@kernel.org>
Date: Tue, 30 Jan 2024 16:47:06 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Mina Almasry <almasrymina@...gle.com>, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
Dumazet <edumazet@...gle.com>, Jason Gunthorpe <jgg@...dia.com>, Christian
König <christian.koenig@....com>, Shakeel Butt
<shakeelb@...gle.com>, Yunsheng Lin <linyunsheng@...wei.com>, Willem de
Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next v6 1/2] net: introduce abstraction for network
memory
On Tue, 30 Jan 2024 10:59:53 +0100 Paolo Abeni wrote:
> > + * netmem_ref - a nonexistent type marking a reference to generic network
>
> Minor nit: here you need to prepend 'struct' to avoid a kdoc warning:
>
> include/net/netmem.h:20: warning: cannot understand function prototype: 'typedef unsigned long __bitwise netmem_ref; '
>
> Should be:
>
> * struct netmem_ref - a nonexistent type marking a reference to generic network
s/struct/typedef/
/**
* typedef netmem_ref - ....
*/
Somewhat surprisingly kdoc understands the typedef keyword just fine :)
Powered by blists - more mailing lists