netdev - Re: [PATCH net-next v8 00/11] stmmac: Add Loongson platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55cec396-6502-4ac2-b1b5-900a0d1a1903@loongson.cn>
Date: Wed, 31 Jan 2024 17:20:54 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Jakub Kicinski <kuba@...nel.org>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, fancer.lancer@...il.com,
 Jose.Abreu@...opsys.com, chenhuacai@...ngson.cn, linux@...linux.org.uk,
 guyinggang@...ngson.cn, netdev@...r.kernel.org, chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v8 00/11] stmmac: Add Loongson platform support


在 2024/1/31 10:10, Jakub Kicinski 写道:
> On Tue, 30 Jan 2024 16:43:20 +0800 Yanteng Si wrote:
>> * The biggest change is according to Serge's comment in the previous
>>    edition:
> Looks like there's a trivial build issue here:
>
> ERROR: modpost: "dwmac1000_dma_ops"
> [drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.ko] undefined!
>
> Please wait for Serge's review before posting v9.

OK!  Will fix with:

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c 
b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
index 5f7b82ad3ec2..0323f0a5049c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
@@ -296,3 +296,4 @@ const struct stmmac_dma_ops dwmac1000_dma_ops = {
         .get_hw_feature = dwmac1000_get_hw_feature,
         .rx_watchdog = dwmac1000_rx_watchdog,
  };
+EXPORT_SYMBOL_GPL(dwmac1000_dma_ops);


Thanks,

Yanteng