netdev - Re: [PATCH vhost 08/17] virtio: vring_new_virtqueue(): pass struct instead of multi parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcd0e35e-e9a3-48b5-fc0a-117ba997439a@linux.intel.com>
Date: Wed, 31 Jan 2024 13:03:04 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
cc: virtualization@...ts.linux.dev, Richard Weinberger <richard@....at>, 
    Anton Ivanov <anton.ivanov@...bridgegreys.com>, 
    Johannes Berg <johannes@...solutions.net>, 
    "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, 
    "David S. Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, Hans de Goede <hdegoede@...hat.com>, 
    Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
    Vadim Pasternak <vadimp@...dia.com>, 
    Bjorn Andersson <andersson@...nel.org>, 
    Mathieu Poirier <mathieu.poirier@...aro.org>, 
    Cornelia Huck <cohuck@...hat.com>, Halil Pasic <pasic@...ux.ibm.com>, 
    Eric Farman <farman@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, 
    Vasily Gorbik <gor@...ux.ibm.com>, 
    Alexander Gordeev <agordeev@...ux.ibm.com>, 
    Christian Borntraeger <borntraeger@...ux.ibm.com>, 
    Sven Schnelle <svens@...ux.ibm.com>, Alexei Starovoitov <ast@...nel.org>, 
    Daniel Borkmann <daniel@...earbox.net>, 
    Jesper Dangaard Brouer <hawk@...nel.org>, 
    John Fastabend <john.fastabend@...il.com>, 
    Benjamin Berg <benjamin.berg@...el.com>, 
    Yang Li <yang.lee@...ux.alibaba.com>, linux-um@...ts.infradead.org, 
    Netdev <netdev@...r.kernel.org>, platform-driver-x86@...r.kernel.org, 
    linux-remoteproc@...r.kernel.org, linux-s390@...r.kernel.org, 
    kvm@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH vhost 08/17] virtio: vring_new_virtqueue(): pass struct
 instead of multi parameters

On Tue, 30 Jan 2024, Xuan Zhuo wrote:

> Just like find_vqs(), it is time to refactor the
> vring_new_virtqueue(). We pass the similar struct to
> vring_new_virtqueue.
> 
> Signed-off-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
> ---

> diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
> index 98ff808d6f0c..37f8c5d34285 100644
> --- a/tools/virtio/vringh_test.c
> +++ b/tools/virtio/vringh_test.c

> @@ -391,7 +391,7 @@ static int parallel_test(u64 features,
>  				/* Swallow all notifies at once. */
>  				if (read(to_guest[0], buf, sizeof(buf)) < 1)
>  					break;
> -				
> +
>  				receives++;
>  				virtqueue_disable_cb(vq);
>  				continue;
> @@ -424,7 +424,7 @@ static int parallel_test(u64 features,
>  				continue;
>  			if (read(to_guest[0], buf, sizeof(buf)) < 1)
>  				break;
> -				
> +

Two unrelated space changes. Please remove them from this patch.


-- 
 i.