netdev - Re: [PATCH net 1/2] net: switchdev: Add helper to check if an object event is pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eddxtyrd.fsf@waldekranz.com>
Date: Wed, 31 Jan 2024 14:31:50 +0100
From: Tobias Waldekranz <tobias@...dekranz.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: davem@...emloft.net, kuba@...nel.org, olteanv@...il.com,
 roopa@...dia.com, razor@...ckwall.org, bridge@...ts.linux.dev,
 netdev@...r.kernel.org, ivecera@...hat.com
Subject: Re: [PATCH net 1/2] net: switchdev: Add helper to check if an
 object event is pending

On ons, jan 31, 2024 at 13:50, Jiri Pirko <jiri@...nulli.us> wrote:
> Wed, Jan 31, 2024 at 01:35:43PM CET, tobias@...dekranz.com wrote:
>>When adding/removing a port to/from a bridge, the port must be brought
>>up to speed with the current state of the bridge. This is done by
>>replaying all relevant events, directly to the port in question.
>
> Could you please use the imperative mood in your patch descriptions?
> That way, it is much easier to understand what is the current state of
> things and what you are actually changing.
>
> https://www.kernel.org/doc/html/v6.7/process/submitting-patches.html#describe-your-changes
>
> While at it, could you also fix your cover letter so the reader can
> actually tell what's the current state and what the patchset is doing?

Sure thing. Do you feel that this is enough of an issue that it blocks
you from doing a review of v1, or can I wait for more feedback and bake
it in with other changes?