[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <65071184-428b-4850-9e0c-baaa73513c6d@lunn.ch>
Date: Wed, 31 Jan 2024 16:17:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Stefan Eichenberger <eichest@...il.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v5 net-next 08/13] net: phy: marvell-88q2xxx: add support
for temperature sensor
> +static int mv88q2xxx_hwmon_probe(struct phy_device *phydev)
> +{
> + struct device *dev = &phydev->mdio.dev;
> + struct device *hwmon;
> + char *hwmon_name;
> + int ret;
> +
> + /* Enable temperature sensor interrupt */
> + ret = phy_set_bits_mmd(phydev, MDIO_MMD_PCS,
> + MDIO_MMD_PCS_MV_TEMP_SENSOR1,
> + MDIO_MMD_PCS_MV_TEMP_SENSOR1_INT_EN);
You enable an interrupt, but i don't see any changes to the interrupt
handler to handle any interrupts which are generated?
Andrew
Powered by blists - more mailing lists