netdev - Re: [PATCH] net: Fix from address in memcpy_to_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcd9223a-debe-4942-bb22-1e4e0f1ae22a@auristor.com>
Date: Wed, 31 Jan 2024 11:54:56 -0500
From: Jeffrey E Altman <jaltman@...istor.com>
To: Michael Lass <bevan@...co.net>, netdev@...r.kernel.org
Cc: David Howells <dhowells@...hat.com>, regressions@...ts.linux.dev
Subject: Re: [PATCH] net: Fix from address in memcpy_to_iter_csum()

On 1/31/2024 10:52 AM, Michael Lass wrote:
> While inlining csum_and_memcpy() into memcpy_to_iter_csum(), the from
> address passed to csum_partial_copy_nocheck() was accidentally changed.
> This causes a regression in applications using UDP, as for example
> OpenAFS, causing loss of datagrams.
>
> Fixes: dc32bff195b4 ("iov_iter, net: Fold in csum_and_memcpy()")
> Cc: David Howells<dhowells@...hat.com>
> Cc:stable@...r.kernel.org
> Cc:regressions@...ts.linux.dev
> Signed-off-by: Michael Lass<bevan@...co.net>
> ---
>   net/core/datagram.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/datagram.c b/net/core/datagram.c
> index 103d46fa0eeb..a8b625abe242 100644
> --- a/net/core/datagram.c
> +++ b/net/core/datagram.c
> @@ -751,7 +751,7 @@ size_t memcpy_to_iter_csum(void *iter_to, size_t progress,
>   			   size_t len, void *from, void *priv2)
>   {
>   	__wsum *csum = priv2;
> -	__wsum next = csum_partial_copy_nocheck(from, iter_to, len);
> +	__wsum next = csum_partial_copy_nocheck(from + progress, iter_to, len);
>   
>   	*csum = csum_block_add(*csum, next, progress);
>   	return 0;

Reviewed-by: Jeffrey Altman <jaltman@...istor.com>

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4039 bytes)