netdev - Re: [PATCH RFC 2/4] tracing: Use uts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240131142729.2fe870ed@gandalf.local.home>
Date: Wed, 31 Jan 2024 14:27:29 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: John Garry <john.g.garry@...cle.com>
Cc: mcgrof@...nel.org, russ.weight@...ux.dev, gregkh@...uxfoundation.org,
 rafael@...nel.org, mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, keescook@...omium.org, masahiroy@...nel.org,
 nathan@...nel.org, nicolas@...sle.eu, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-kbuild@...r.kernel.org
Subject: Re: [PATCH RFC 2/4] tracing: Use uts_release

On Wed, 31 Jan 2024 10:48:49 +0000
John Garry <john.g.garry@...cle.com> wrote:

> Instead of using UTS_RELEASE, use uts_release, which means that we don't
> need to rebuild the code just for the git head commit changing.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> ---
>  kernel/trace/trace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 2a7c6fd934e9..68513924beb4 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -13,7 +13,7 @@
>   *  Copyright (C) 2004 Nadia Yvette Chambers
>   */
>  #include <linux/ring_buffer.h>
> -#include <generated/utsrelease.h>
> +#include <linux/utsname.h>
>  #include <linux/stacktrace.h>
>  #include <linux/writeback.h>
>  #include <linux/kallsyms.h>
> @@ -4354,7 +4354,7 @@ print_trace_header(struct seq_file *m, struct trace_iterator *iter)
>  	get_total_entries(buf, &total, &entries);
>  
>  	seq_printf(m, "# %s latency trace v1.1.5 on %s\n",
> -		   name, UTS_RELEASE);
> +		   name, uts_release);
>  	seq_puts(m, "# -----------------------------------"
>  		 "---------------------------------\n");
>  	seq_printf(m, "# latency: %lu us, #%lu/%lu, CPU#%d |"