[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a1e54836-51d2-4990-9444-56d9414eb28c@lunn.ch>
Date: Wed, 31 Jan 2024 23:40:45 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>,
Bastien Curutchet <bastien.curutchet@...tlin.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Richard Cochran <richardcochran@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Herve Codina <herve.codina@...tlin.com>
Subject: Re: [PATCH 1/2] dt-bindings: net: Add TI DP83640
On Wed, Jan 31, 2024 at 09:18:39PM +0000, Conor Dooley wrote:
> On Wed, Jan 31, 2024 at 03:05:21PM -0600, Rob Herring wrote:
> > On Tue, Jan 30, 2024 at 05:56:37PM +0000, Conor Dooley wrote:
> > > On Tue, Jan 30, 2024 at 09:59:34AM +0100, Bastien Curutchet wrote:
>
> > > > + ti,fiber-mode:
> > > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > > + enum: [0, 1]
> > > > + description: |
> > > > + If present, enables or disables the FX Fiber Mode.
> > > > + Fiber mode support can also be strapped. If the strap pin is not set
> > > > + correctly or not set at all then this can be used to configure it.
> > > > + - 0 = FX Fiber Mode disabled
> > > > + - 1 = FX Fiber Mode enabled
> > > > + - unset = Configured by straps
> > >
> > > I don't like these properties that map meanings onto numbers. We can
> > > have enums of strings in bindings that allow you to use something more
> > > meaningful than "0" or "1".
> >
> > Tristate properties are fairly common pattern where we need
> > on/off/default. I've thought about making it a type. I don't think we
> > need defines for it.
>
> I think a type would be a good idea. I am not at all a fan of any of the
> properties people introduce along these lines.
Before going too far with that, i'm not actually sure it is required
here. I've not looked at the PHY driver itself, but i expect there is
some indication somewhere that the network stack expects a fibre link
is to be used. We probably can determine at runtime if fibre should be
used.
Andrew
Powered by blists - more mailing lists