netdev - Re: [RFC PATCH v3 net-next] Documentation: devlink: Add devlink-sd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc9f44a8-857b-498a-8b8c-3445e4749366@nvidia.com>
Date: Wed, 31 Jan 2024 15:02:58 -0800
From: William Tu <witu@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>
Cc: bodong@...dia.com, jiri@...dia.com, netdev@...r.kernel.org,
 saeedm@...dia.com,
 "aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>
Subject: Re: [RFC PATCH v3 net-next] Documentation: devlink: Add devlink-sd


On 1/31/24 2:30 PM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, 31 Jan 2024 13:41:07 -0800 Jacob Keller wrote:
>>>> Still, I feel like shared buffer pools / shared queues is how majority
>>>> of drivers implement representors. Did you had a look around?
>>> Yes, I look at Intel ICE driver, which also has representors. (Add to CC)
>>>
>>> IIUC, it's still dedicated buffer for each reps, so this new API might help.
>> Yea, I am pretty sure the ice implementation uses dedicated buffers for
>> representors right now.
> I just did a grep on METADATA_HW_PORT_MUX and assumed bnxt, ice and nfp
> all do buffer sharing. You're saying you mux Tx queues but not Rx
> queues? Or I need to actually read the code instead of grepping? :)
>
I guess bnxt, ice, nfp are doing tx buffer sharing?


This devlink sd is for RX queues not TX queues.

And devlink-sd creates a pool of shared descriptors only for RX queue.

The TX queues/ TX path remain unchanged.

William