netdev - Re: [PATCH net] selftests: net: add missing config for big tcp tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240130171817.1572c29f@kernel.org>
Date: Tue, 30 Jan 2024 17:18:17 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Shuah Khan <shuah@...nel.org>, Xin Long
 <lucien.xin@...il.com>, Florian Westphal <fw@...len.de>, Aaron Conole
 <aconole@...hat.com>, Nikolay Aleksandrov <razor@...ckwall.org>,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: net: add missing config for big tcp
 tests

On Tue, 30 Jan 2024 19:41:10 +0100 Paolo Abeni wrote:
> > Yes, it's VM inside a VM without nested virtualization support.
> > A weird setup, granted, but when we move to bare metal I'd like
> > to enable KASAN, which will probably cause a similar slowdown..
> > 
> > You could possibly get a similar slowdown by disabling HW virt /
> > KVM?  
> 
> Thanks, the above helped - that is, I can reproduce the failure running
> the self-tests in a VM with KVM disabled in the host. Funnily enough I
> can't use plain virtme for that - the virtme VM crashes on boot,
> possibly due to the wrong 'machine' argument passed to qemu.

FWIW I think you can fix this by passing -o " -cpu Haswell" to vng. 
Yet another piece of knowledge I wish I didn't have and which I should
probably put somewhere public :(

> In any case I can't see a sane way to cope with such slow environments
> except skipping the sensitive cases.
> 
> > FWIW far the 4 types of issues we've seen were:
> >  - config missing
> >  - OS doesn't ifup by default
> >  - OS tools are old / buggy
> >  - VM-in-VM is just too slow.
> > 
> > There's a bunch of failures in forwarding which look like perf issues.
> > I wonder if we should introduce something in the settings file to let
> > tests know that they are running in very slow env?  
> 
> I was wondering about passing such info to the test e.g. via an env
> variable:
> 
> vng --run . --user root -- HOST_IS_DAMN_SLOW=true
> ./tools/testing/selftests/kselftest_install/run_kselftest.sh -t
> <whatever>
> 
> In any case some tests should be updated to skip the relevant cases
> accordingly, right?

Which reminds me I need to send the meeting notes from the netdev call
:) We went with KSFT_MACHINE_SLOW=yes for now, the NIPA machines should
have it set now.