netdev - Re: [PATCH net-next 2/5] net/ipv6: Remove unnecessary clean.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZboE35ahg7t-YSMC@Laptop-X1>
Date: Wed, 31 Jan 2024 16:29:19 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: thinker.li@...il.com
Cc: netdev@...r.kernel.org, ast@...nel.org, martin.lau@...ux.dev,
	kernel-team@...a.com, davem@...emloft.net, dsahern@...nel.org,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	sinquersw@...il.com, kuifeng@...a.com
Subject: Re: [PATCH net-next 2/5] net/ipv6: Remove unnecessary clean.

On Tue, Jan 30, 2024 at 10:40:38PM -0800, thinker.li@...il.com wrote:
> From: Kui-Feng Lee <thinker.li@...il.com>
> 
> The route here is newly created. It is unnecessary to call
> fib6_clean_expires() on it.
> 
> Signed-off-by: Kui-Feng Lee <thinker.li@...il.com>
> ---
>  net/ipv6/route.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 98abba8f15cd..dd6ff5b20918 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -3765,8 +3765,6 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
>  	if (cfg->fc_flags & RTF_EXPIRES)
>  		fib6_set_expires(rt, jiffies +
>  				clock_t_to_jiffies(cfg->fc_expires));
> -	else
> -		fib6_clean_expires(rt);
>  
>  	if (cfg->fc_protocol == RTPROT_UNSPEC)
>  		cfg->fc_protocol = RTPROT_BOOT;
> -- 
> 2.34.1
> 

Reviewed-by: Hangbin Liu <liuhangbin@...il.com>