netdev - Re: [PATCH net 1/2] net: switchdev: Add helper to check if an object event is pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZbtMEOIDA_6CgRVp@nanopsycho>
Date: Thu, 1 Feb 2024 08:45:20 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Tobias Waldekranz <tobias@...dekranz.com>, davem@...emloft.net,
	kuba@...nel.org, roopa@...dia.com, razor@...ckwall.org,
	bridge@...ts.linux.dev, netdev@...r.kernel.org, ivecera@...hat.com
Subject: Re: [PATCH net 1/2] net: switchdev: Add helper to check if an object
 event is pending

Thu, Feb 01, 2024 at 01:33:05AM CET, olteanv@...il.com wrote:
>On Wed, Jan 31, 2024 at 01:50:11PM +0100, Jiri Pirko wrote:
>> Wed, Jan 31, 2024 at 01:35:43PM CET, tobias@...dekranz.com wrote:
>> >When adding/removing a port to/from a bridge, the port must be brought
>> >up to speed with the current state of the bridge. This is done by
>> >replaying all relevant events, directly to the port in question.
>> 
>> Could you please use the imperative mood in your patch descriptions?
>> That way, it is much easier to understand what is the current state of
>> things and what you are actually changing.
>
>FWIW, the paragraph you've concentrated upon does describe the current
>state of things, not what the patch does; thus it does not need to be in
>the imperative mood.

Well, there is no imperative mood in the next paragraph either :)
Therefore from the patch desctiption pow now clue what the patch is doing.