netdev - Re: [PATCH net-next] selftests: net: Fix bridge backup port test flakiness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cca1f0d3c015a6ab9e371b1639f6c3c29b33024.camel@redhat.com>
Date: Thu, 01 Feb 2024 10:34:52 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 shuah@...nel.org,  razor@...ckwall.org
Subject: Re: [PATCH net-next] selftests: net: Fix bridge backup port test
 flakiness

On Thu, 2024-02-01 at 10:05 +0200, Ido Schimmel wrote:
> The test toggles the carrier of a bridge port in order to test the
> bridge backup port feature.
> 
> Due to the linkwatch delayed work the carrier change is not always
> reflected fast enough to the bridge driver and packets are not forwarded
> as the test expects, resulting in failures [1].
> 
> Fix by adding a one second delay after a carrier change in places where
> a packet is sent immediately after the carrier change.

What about adding an helper alike wait_local_port_listen(), checking
for bridge link status in short intervals, to likely reduce the overall
wait time?

Thanks,

Paolo