[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADFiAc+y_SXGtVqZkLoiWw-YBArMovMkuWw3X596QDwEtdBJ2g@mail.gmail.com>
Date: Thu, 1 Feb 2024 09:59:27 +0900
From: takeru hayasaka <hayatake396@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, intel-wired-lan@...ts.osuosl.org,
netdev@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, mailhol.vincent@...adoo.fr,
vladimir.oltean@....com, laforge@...monks.org
Subject: Re: [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP
from ethtool
Hi Jakub-san
Thank you for your review.
I apologize for the delay in resubmitting the patch.
> Could you split the uAPI changes and the driver changes to two separate
> commits? You should post them as a patch series, but combining them
> into a single commit makes the uAPI addition to easy to miss.
Understood. I will split the patches and submit them separately in v7.
Thanks
Takeru
2024年2月1日(木) 6:13 Jakub Kicinski <kuba@...nel.org>:
>
> On Wed, 31 Jan 2024 13:46:22 +0000 Takeru Hayasaka wrote:
> > .../device_drivers/ethernet/intel/ice.rst | 21 ++++-
> > drivers/net/ethernet/intel/ice/ice_ethtool.c | 82 +++++++++++++++++++
> > drivers/net/ethernet/intel/ice/ice_flow.h | 31 +++++--
> > drivers/net/ethernet/intel/ice/ice_lib.c | 37 +++++++++
> > include/uapi/linux/ethtool.h | 48 +++++++++++
>
> Could you split the uAPI changes and the driver changes to two separate
> commits? You should post them as a patch series, but combining them
> into a single commit makes the uAPI addition to easy to miss.
> --
> pw-bot: cr
Powered by blists - more mailing lists