netdev - Re: [net-next v7 4/4] net: wwan: t7xx: Add fastboot WWAN port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbvC7E_J7U6zBwJD@nanopsycho>
Date: Thu, 1 Feb 2024 17:12:28 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jinjian Song <songjinjian@...mail.com>
Cc: netdev@...r.kernel.org, chandrashekar.devegowda@...el.com,
	chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com,
	m.chetan.kumar@...ux.intel.com, ricardo.martinez@...ux.intel.com,
	loic.poulain@...aro.org, ryazanov.s.a@...il.com,
	johannes@...solutions.net, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.com,
	vsankar@...ovo.com, letitia.tsai@...com, pin-hao.huang@...com,
	danielwinkler@...gle.com, nmarupaka@...gle.com,
	joey.zhao@...ocom.com, liuqf@...ocom.com, felix.yan@...ocom.com,
	angel.huang@...ocom.com, freddy.lin@...ocom.com,
	alan.zhang1@...ocom.com, zhangrc@...ocom.com,
	Jinjian Song <jinjian.song@...ocom.com>
Subject: Re: [net-next v7 4/4] net: wwan: t7xx: Add fastboot WWAN port

Thu, Feb 01, 2024 at 04:13:40PM CET, songjinjian@...mail.com wrote:
>From: Jinjian Song <jinjian.song@...ocom.com>

[...]

>+static void t7xx_port_wwan_create(struct t7xx_port *port)
>+{
>+	const struct t7xx_port_conf *port_conf = port->port_conf;
>+	unsigned int header_len = sizeof(struct ccci_header), mtu;
>+	struct wwan_port_caps caps;
>+
>+	if (!port->wwan.wwan_port) {
>+		mtu = t7xx_get_port_mtu(port);
>+		caps.frag_len = mtu - header_len;
>+		caps.headroom_len = header_len;
>+		port->wwan.wwan_port = wwan_create_port(port->dev, port_conf->port_type,
>+							&wwan_ops, &caps, port);
>+		if (IS_ERR(port->wwan.wwan_port))
>+			dev_err(port->dev, "Unable to create WWWAN port %s", port_conf->name);

To many "W"s.

>+	}
>+}

[...]