netdev - Re: [Intel-wired-lan] [PATCH net] ice: fix unaligned access in ice_create_lag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 1 Feb 2024 19:40:17 +0100
From: Michal Schmidt <mschmidt@...hat.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>,
 Jiri Pirko <jiri@...nulli.us>
Cc: Daniel Machon <daniel.machon@...rochip.com>, netdev@...r.kernel.org,
 Jesse Brandeburg <jesse.brandeburg@...el.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 Dave Ertman <david.m.ertman@...el.com>, intel-wired-lan@...ts.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net] ice: fix unaligned access in
 ice_create_lag_recipe

On 1/31/24 17:59, Alexander Lobakin wrote:
> From: Jiri Pirko <jiri@...nulli.us>
> Date: Wed, 31 Jan 2024 13:17:44 +0100
> 
>> Wed, Jan 31, 2024 at 12:58:23PM CET, mschmidt@...hat.com wrote:
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c b/drivers/net/ethernet/intel/ice/ice_lag.c
>>> index 2a25323105e5..d4848f6fe919 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_lag.c
>>> +++ b/drivers/net/ethernet/intel/ice/ice_lag.c
>>> @@ -1829,9 +1829,7 @@ static int ice_create_lag_recipe(struct ice_hw *hw, u16 *rid,
>>> 	new_rcp->content.act_ctrl_fwd_priority = prio;
>>> 	new_rcp->content.rid = *rid | ICE_AQ_RECIPE_ID_IS_ROOT;
>>> 	new_rcp->recipe_indx = *rid;
>>> -	bitmap_zero((unsigned long *)new_rcp->recipe_bitmap,
>>> -		    ICE_MAX_NUM_RECIPES);
>>> -	set_bit(*rid, (unsigned long *)new_rcp->recipe_bitmap);
>>> +	put_unaligned_le64(BIT_ULL(*rid), new_rcp->recipe_bitmap);
>>
>> Looks like there might be another incorrect bitmap usage for this in
>> ice_add_sw_recipe(). Care to fix it there as well?
> 
> Those are already fixed in one switchdev series and will be sent to IWL
> soon.
> I believe this patch would also make no sense after it's sent.

Hi Alexander,
When will the series be sent?
The bug causes a kernel panic. Will the series target net.git?
Michal