netdev - Re: Re: [PATCH v10 net-next 02/15] net/sched: act_api: increase action kind string length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnP8ZZ+=L0gWRc-kJUH51gfPW-aO0M16SDRk7O_qD=D3LreVw@mail.gmail.com>
Date: Thu, 1 Feb 2024 11:01:46 -0800
From: Marcelo Ricardo Leitner <mleitner@...hat.com>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: netdev@...r.kernel.org, deb.chatterjee@...el.com, anjali.singhai@...el.com, 
	namrata.limaye@...el.com, tom@...anda.io, Mahesh.Shirshyad@....com, 
	tomasz.osinski@...el.com, jiri@...nulli.us, xiyou.wangcong@...il.com, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	vladbu@...dia.com, horms@...nel.org, khalidm@...dia.com, toke@...hat.com, 
	mattyk@...dia.com, daniel@...earbox.net, bpf@...r.kernel.org
Subject: Re: Re: [PATCH v10 net-next 02/15] net/sched: act_api: increase
 action kind string length

On Thu, Feb 01, 2024 at 05:16:44AM -0800, Marcelo Ricardo Leitner wrote:
> On Mon, Jan 22, 2024 at 02:47:48PM -0500, Jamal Hadi Salim wrote:
> > @@ -1439,7 +1439,7 @@ tc_action_load_ops(struct net *net, struct nlattr *nla,
> >  			NL_SET_ERR_MSG(extack, "TC action kind must be specified");
> >  			return ERR_PTR(err);
> >  		}
> > -		if (nla_strscpy(act_name, kind, IFNAMSIZ) < 0) {
> > +		if (nla_strscpy(act_name, kind, ACTNAMSIZ) < 0) {
> >  			NL_SET_ERR_MSG(extack, "TC action name too long");
> >  			return ERR_PTR(err);
> >  		}
>
> Subsquent lines here are:
>         } else {
>                 if (strscpy(act_name, "police", IFNAMSIZ) < 0) {
> 		                                ^^^^^^^^
>                         NL_SET_ERR_MSG(extack, "TC action name too long");
>
> I know it won't make a difference in the end but it would be nice to
> keep it consistent.
>

Despite this, please add my tag in the next iteration:

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>