netdev - Re: [PATCH net] netdevsim: avoid potential loop in nsim_dev_trap_report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+MLtYa9kxc4r_etSrz87hoMF8L_HHbJXtaNEU7C22-Ng@mail.gmail.com>
Date: Thu, 1 Feb 2024 21:10:46 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, syzbot <syzkaller@...glegroups.com>, 
	Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net] netdevsim: avoid potential loop in nsim_dev_trap_report_work()

On Thu, Feb 1, 2024 at 7:49 PM Paolo Abeni <pabeni@...hat.com> wrote:
>

> The patch LGTM, thanks!
>
> I'm wondering if we have a similar problem in
> devlink_rel_nested_in_notify_work():
>
>         if (!devl_trylock(devlink)) {
>                 devlink_put(devlink);
>                 goto reschedule_work;
>         }
>
>         //...
> reschedule_work:
>         schedule_work(&rel->nested_in.notify_work);
>

> And possibly adding 1ms delay there could be problematic?

A conversion to schedule_delayed_work() would be needed I think.

I looked at all syzbot reports and did not find
devlink_rel_nested_in_notify_work() in them,
I guess we were lucky all this time :)

>
> Cheers,
>
> Paolo
>