netdev - Re: [PATCHv2 net-next 2/4] selftests: bonding: use tc filter to check if LACP was sent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zbs9r16e3FdhHIkH@Laptop-X1>
Date: Thu, 1 Feb 2024 14:43:59 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: netdev@...r.kernel.org
Cc: Jay Vosburgh <j.vosburgh@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, Liang Li <liali@...hat.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCHv2 net-next 2/4] selftests: bonding: use tc filter to
 check if LACP was sent

On Thu, Feb 01, 2024 at 02:29:52PM +0800, Hangbin Liu wrote:
> Use tc filter to check if LACP was sent, which is accurate and save
> more time.
> 
> No need to remove bonding module as some test env may buildin bonding.
> And the bond link has been deleted.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  .../net/bonding/bond-break-lacpdu-tx.sh       | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh b/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> index 6358df5752f9..01dcf501da41 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> @@ -20,21 +20,21 @@
>  #    +------+ +------+
>  #
>  # We use veths instead of physical interfaces
> +REQUIRE_MZ=no
> +NUM_NETIFS=0
> +lib_dir=$(dirname "$0")
> +source "$lib_dir"/net_forwarding_lib.sh

Opps, forgot to rebase to latest net-next, which merged Benjamin's lib update.

I will post new version tomorrow.

Thanks
Hangbin