[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240202102231.GK530335@kernel.org>
Date: Fri, 2 Feb 2024 11:22:31 +0100
From: Simon Horman <horms@...nel.org>
To: David Wei <dw@...idwei.uk>
Cc: Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>,
Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v7 3/4] netdevsim: add selftest for forwarding
skb between connected ports
On Tue, Jan 30, 2024 at 10:57:45AM -0800, David Wei wrote:
> On 2024-01-29 12:34, Simon Horman wrote:
> > On Fri, Jan 26, 2024 at 08:03:53PM -0800, David Wei wrote:
> >> Connect two netdevsim ports in different namespaces together, then send
> >> packets between them using socat.
> >>
> >> Signed-off-by: David Wei <dw@...idwei.uk>
> >> ---
> >> .../selftests/drivers/net/netdevsim/peer.sh | 127 ++++++++++++++++++
> >> 1 file changed, 127 insertions(+)
> >> create mode 100755 tools/testing/selftests/drivers/net/netdevsim/peer.sh
> >>
> >> diff --git a/tools/testing/selftests/drivers/net/netdevsim/peer.sh b/tools/testing/selftests/drivers/net/netdevsim/peer.sh
> >> new file mode 100755
> >> index 000000000000..05f3cefa53f3
> >> --- /dev/null
> >> +++ b/tools/testing/selftests/drivers/net/netdevsim/peer.sh
> >> @@ -0,0 +1,127 @@
> >> +#!/bin/bash
> >> +# SPDX-License-Identifier: GPL-2.0-only
> >> +
> >> +NSIM_DEV_1_ID=$((RANDOM % 1024))
> >> +NSIM_DEV_1_SYS=/sys/bus/netdevsim/devices/netdevsim$NSIM_DEV_1_ID
> >> +NSIM_DEV_1_DFS=/sys/kernel/debug/netdevsim/netdevsim$NSIM_DEV_1_ID
> >> +NSIM_DEV_2_ID=$((RANDOM % 1024))
> >> +NSIM_DEV_2_SYS=/sys/bus/netdevsim/devices/netdevsim$NSIM_DEV_2_ID
> >> +NSIM_DEV_2_DFS=/sys/kernel/debug/netdevsim/netdevsim$NSIM_DEV_2_ID
> >
> > nit: NSIM_DEV_1_DFS and SIM_DEV_2_DFS appear to be unused.
> >
> > Flagged by shellcheck.
> >
> > ...
>
> Hi Simon, thanks for flagging this, these were leftover from previous
> changes. I'll remove them in the next version.
Thanks David,
much appreciated.
Powered by blists - more mailing lists