netdev - Re: [PATCH RESUBMIT net-next] r8169: simplify EEE handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 21:36:26 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>,
 Realtek linux nic maintainers <nic_swsd@...ltek.com>,
 David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH RESUBMIT net-next] r8169: simplify EEE handling

On 02.02.2024 17:15, Jakub Kicinski wrote:
> On Fri, 2 Feb 2024 17:06:10 +0100 Heiner Kallweit wrote:
>>>> Alternative would be to change phy_advertise_supported(), but this may
>>>> impact systems with PHY's with EEE flaws.  
>>>
>>> If i remember correctly, there was some worry enabling EEE by default
>>> could upset some low latency use cases, PTP accuracy etc. So lets
>>> leave it as it is. Maybe a helper would be useful
>>> phy_advertise_eee_all() with a comment about why it could be used.
>>>   
>> Yes, I think that's the way to go.
>> To minimize efforts I'd like to keep this patch here as it is, then I'll
>> add the helper and change this place in r8169 to use the new helper.
> 
> Sorry for being slow - on top or as v2? :)

I'll do it on top.