netdev - Re: [PATCH v1 net-next 07/16] af_unix: Detect Strongly Connected Components.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202402040348.uejoTcrq-lkp@intel.com>
Date: Sun, 4 Feb 2024 03:59:15 +0800
From: kernel test robot <lkp@...el.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH v1 net-next 07/16] af_unix: Detect Strongly Connected
 Components.

Hi Kuniyuki,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/af_unix-Add-struct-unix_vertex-in-struct-unix_sock/20240203-110847
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240203030058.60750-8-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 07/16] af_unix: Detect Strongly Connected Components.
config: x86_64-rhel-8.3-bpf (https://download.01.org/0day-ci/archive/20240204/202402040348.uejoTcrq-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240204/202402040348.uejoTcrq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402040348.uejoTcrq-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/unix/garbage.c:257:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions]
     257 |         }
         |         ^
   1 warning generated.


vim +257 net/unix/garbage.c

   227	
   228	static void __unix_walk_scc(struct unix_vertex *vertex)
   229	{
   230		unsigned long index = UNIX_VERTEX_INDEX_START;
   231		LIST_HEAD(vertex_stack);
   232		struct unix_edge *edge;
   233		LIST_HEAD(edge_stack);
   234	
   235	next_vertex:
   236		vertex->index = index;
   237		vertex->lowlink = index;
   238		index++;
   239	
   240		vertex->on_stack = true;
   241		list_move(&vertex->scc_entry, &vertex_stack);
   242	
   243		list_for_each_entry(edge, &vertex->edges, entry) {
   244			if (!edge->successor->out_degree)
   245				continue;
   246	
   247			if (edge->successor->index == UNIX_VERTEX_INDEX_UNVISITED) {
   248				list_add(&edge->stack_entry, &edge_stack);
   249	
   250				vertex = edge->successor;
   251				goto next_vertex;
   252			}
   253	
   254			if (edge->successor->on_stack)
   255				vertex->lowlink = min(vertex->lowlink, edge->successor->index);
   256	next_edge:
 > 257		}
   258	
   259		if (vertex->index == vertex->lowlink) {
   260			LIST_HEAD(scc);
   261	
   262			list_cut_position(&scc, &vertex_stack, &vertex->scc_entry);
   263	
   264			list_for_each_entry_reverse(vertex, &scc, scc_entry) {
   265				list_move_tail(&vertex->entry, &unix_visited_vertices);
   266	
   267				vertex->on_stack = false;
   268			}
   269	
   270			list_del(&scc);
   271		}
   272	
   273		if (!list_empty(&edge_stack)) {
   274			edge = list_first_entry(&edge_stack, typeof(*edge), stack_entry);
   275			list_del_init(&edge->stack_entry);
   276	
   277			vertex = edge->predecessor;
   278			vertex->lowlink = min(vertex->lowlink, edge->successor->lowlink);
   279			goto next_edge;
   280		}
   281	}
   282	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki