netdev - Re: [PATCH net-next 1/2] net: phy: add helper phy_advertise_eee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a1cf78a-0516-4696-b08d-c149a195457f@lunn.ch>
Date: Sat, 3 Feb 2024 17:16:57 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: add helper phy_advertise_eee_all

On Sat, Feb 03, 2024 at 12:20:12PM +0100, Heiner Kallweit wrote:
> Per default phylib preserves the EEE advertising at the time of
> phy probing. The EEE advertising can be changed from user space,
> in addition this helper allows to set the EEE advertising to all
> supported modes from drivers in kernel space.
> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/phy/phy_device.c | 12 ++++++++++++
>  include/linux/phy.h          |  1 +
>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index dd778c7fd..df56c3ebf 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -2769,6 +2769,18 @@ void phy_advertise_supported(struct phy_device *phydev)
>  }
>  EXPORT_SYMBOL(phy_advertise_supported);
>  
> +/**
> + * phy_advertise_eee_all - Advertise all supported EEE modes
> + * @phydev: target phy_device struct
> + *
> + * Description: Called to advertise all supported EEE modes
> + */

I would expand this description. Include the

Per default phylib preserves the EEE advertising at the time of
phy probing

And extend with something like,

which might be a subset of the supported EEE modes. Use this function
when all supported EEE modes should be advertised. This does not
trigger auto-negotiation, so must be called before
phy_start()/phylink_start() which will start auto-negotiation.

	Andrew