netdev - Re: qca_spi: SPI_REG_SIGNATURE sometimes not recognized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6c64849-ded6-49e0-aa15-283346b185e4@gmx.net>
Date: Sun, 4 Feb 2024 22:52:08 +0100
From: Stefan Wahren <wahrenst@....net>
To: chf.fritz@...glemail.com
Cc: netdev <netdev@...r.kernel.org>
Subject: Re: qca_spi: SPI_REG_SIGNATURE sometimes not recognized

Hello Christoph,

Am 04.02.24 um 22:23 schrieb Christoph Fritz:
> Hello Stefan,
>
>   working on a board with QCA7005, on probe() SPI_REG_SIGNATURE
> sometimes fails (~1 out of 5 times) to be recognized correctly, even
> after multiple reads and retries.
at the time of writing the driver, i assumed the QCA7000 is always
powered up (takes ~ 1 second) during probe of the driver and the driver
could do the signature check during probe. But this doesn't work in all
cases. So qca_spi driver has the module parameter qcaspi_pluggable,
which is disabled per default. If you enable this, this will skip the
signature check during probe and let the spi thread handle the
synchronization.

Does this fix your problem?

Regardless of the results, i think qcaspi_pluggable should be enabled
per default.

Regards

>
> Any suggestions?
>
> Thanks
>   -- Christoph