netdev - Re: [PATCH v2 net-next 15/16] bridge: use exit_batch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240203211052.30905ae4@kernel.org>
Date: Sat, 3 Feb 2024 21:10:52 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Antoine Tenart <atenart@...nel.org>,
 netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 15/16] bridge: use exit_batch_rtnl() method

On Fri,  2 Feb 2024 17:40:00 +0000 Eric Dumazet wrote:
> exit_batch_rtnl() is called while RTNL is held,
> and devices to be unregistered can be queued in the dev_kill_list.
> 
> This saves one rtnl_lock()/rtnl_unlock() pair per netns
> and one unregister_netdevice_many() call.

This one appears to cause a lot of crashes in the selftests:

https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-02-03--21-00&pw-n=0&pass=0

Example crash:

https://netdev-2.bots.linux.dev/vmksft-bonding/results/449900/vm-crash-thr0-2
-- 
pw-bot: cr