netdev - Re: [PATCH net-next v3 4/5] net/ipv6: set expires in modify_prefix_route() if RTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zb9kRrG_7LRl1i2W@Laptop-X1>
Date: Sun, 4 Feb 2024 18:17:42 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Kui-Feng Lee <sinquersw@...il.com>
Cc: thinker.li@...il.com, netdev@...r.kernel.org, ast@...nel.org,
	martin.lau@...ux.dev, kernel-team@...a.com, davem@...emloft.net,
	dsahern@...nel.org, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, kuifeng@...a.com
Subject: Re: [PATCH net-next v3 4/5] net/ipv6: set expires in
 modify_prefix_route() if RTF_EXPIRES is set.

On Fri, Feb 02, 2024 at 09:57:46AM -0800, Kui-Feng Lee wrote:
> > Hi Kui-Feng,
> > 
> > I may missed something. But I still could not get why we shouldn't use
> > expires for checking? If expires == 0, but RTF_EXPIRES is on,
> > shouldn't we call fib6_clean_expires()?
> 
> 
> The case that expires == 0 and RTF_EXPIES is on never happens since
> inet6_addr_modify() rejects valid_lft == 0 at the beginning. This
> patch doesn't make difference logically, but make inet6_addr_modify()
> and modify_prefix_route() consistent.
> 
> Does that make sense to you?

Thanks, this does make sense to me. If there will be a new version. It would
be good to add the following sentence in the description.

"""
This patch doesn't make difference logically, but make inet6_addr_modify()
and modify_prefix_route() consistent.
"""

Reviewed-by: Hangbin Liu <liuhangbin@...il.com>

Regards
Hangbin