netdev - Re: [PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe192b1d-da96-4f58-abe2-c3447adf0676@infradead.org>
Date: Sun, 4 Feb 2024 07:43:28 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Jon Maloy <jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>,
 linux-kernel@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH] net: tipc: remove redundant 'bool' from
 CONFIG_TIPC_{MEDIA_UDP,CRYPTO}



On 2/4/24 05:12, Masahiro Yamada wrote:
> The 'bool' is already specified for these options.
> 
> The second 'bool' under the help message is redundant.
> 
> While I am here, I moved 'default y' above, as it is common to place
> the help text last.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
> 
>  net/tipc/Kconfig | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig
> index be1c4003d67d..bb0d71eb02a6 100644
> --- a/net/tipc/Kconfig
> +++ b/net/tipc/Kconfig
> @@ -32,16 +32,17 @@ config TIPC_MEDIA_UDP
>  	bool "IP/UDP media type support"
>  	depends on TIPC
>  	select NET_UDP_TUNNEL
> +	default y
>  	help
>  	  Saying Y here will enable support for running TIPC over IP/UDP
> -	bool
> -	default y
> +
>  config TIPC_CRYPTO
>  	bool "TIPC encryption support"
>  	depends on TIPC
>  	select CRYPTO
>  	select CRYPTO_AES
>  	select CRYPTO_GCM
> +	default y
>  	help
>  	  Saying Y here will enable support for TIPC encryption.
>  	  All TIPC messages will be encrypted/decrypted by using the currently most
> @@ -49,8 +50,6 @@ config TIPC_CRYPTO
>  	  entering the TIPC stack.
>  	  Key setting from user-space is performed via netlink by a user program
>  	  (e.g. the iproute2 'tipc' tool).
> -	bool
> -	default y
>  
>  config TIPC_DIAG
>  	tristate "TIPC: socket monitoring interface"

-- 
#Randy