netdev - Re: [PATCH net] ps3/gelic: Fix SKB allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c581c16-85c5-40c9-9f44-5fa7c39ceeed@infradead.org>
Date: Mon, 5 Feb 2024 09:08:29 +0900
From: Geoff Levand <geoff@...radead.org>
To: Paolo Abeni <pabeni@...hat.com>, sambat goson <sombat3960@...il.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 "David S. Miller" <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ps3/gelic: Fix SKB allocation

Hi Paolo,

On 1/30/24 21:37, Paolo Abeni wrote:
> Hi,
> 
> On Fri, 2024-01-26 at 18:25 +0900, Geoff Levand wrote:
>> Commit 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures")
>> of 6.8-rc1 did not set up the ps3 gelic network SKB's correctly,
>> resulting in a kernel panic.
>>     
>> This fix changes the way the napi buffer and corresponding SKB are
>> allocated and managed.
>>     
>> Reported-by: sambat goson <sombat3960@...il.com>
>> Fixes: 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures")
>> Signed-off-by: Geoff Levand <geoff@...radead.org>
> 
> The patch overall looks correct to me, but there are a few formal
> issues worthy to be addressed, see below.

Thanks for the review.  I'll send out an updated patch sometime soon.

-Geoff