netdev - Re: [PATCH net-next v3 1/5] net/ipv6: set expires in rt6_add_dflt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51bb9972-70e5-4f65-9ab2-35e17d6c1467@kernel.org>
Date: Sun, 4 Feb 2024 21:42:12 -0700
From: David Ahern <dsahern@...nel.org>
To: thinker.li@...il.com, netdev@...r.kernel.org, ast@...nel.org,
 martin.lau@...ux.dev, kernel-team@...a.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, liuhangbin@...il.com
Cc: sinquersw@...il.com, kuifeng@...a.com
Subject: Re: [PATCH net-next v3 1/5] net/ipv6: set expires in
 rt6_add_dflt_router().

On 2/2/24 1:21 AM, thinker.li@...il.com wrote:
> From: Kui-Feng Lee <thinker.li@...il.com>
> 
> Pass the duration of a lifetime (in seconds) to the function
> rt6_add_dflt_router() so that it can properly set the expiration time.
> 
> The function ndisc_router_discovery() is the only one that calls
> rt6_add_dflt_router(), and it will later set the expiration time for the
> route created by rt6_add_dflt_router(). However, there is a gap of time
> between calling rt6_add_dflt_router() and setting the expiration time in
> ndisc_router_discovery(). During this period, there is a possibility that a
> new route may be removed from the routing table. By setting the correct
> expiration time in rt6_add_dflt_router(), we can prevent this from
> happening. The reason for setting RTF_EXPIRES in rt6_add_dflt_router() is
> to start the Garbage Collection (GC) timer, as it only activates when a
> route with RTF_EXPIRES is added to a table.
> 
> Signed-off-by: Kui-Feng Lee <thinker.li@...il.com>
> ---
>  include/net/ip6_route.h | 3 ++-
>  net/ipv6/ndisc.c        | 3 ++-
>  net/ipv6/route.c        | 4 +++-
>  3 files changed, 7 insertions(+), 3 deletions(-)
> 


Suggested-by: David Ahern <dsahern@...nel.org>
Reviewed-by: David Ahern <dsahern@...nel.org>