netdev - Re: [PATCH] net: make driver settling time configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfbad418-f8c6-4cdf-97b5-5c13044539e8@davidv.dev>
Date: Mon, 5 Feb 2024 15:31:38 +0100
From: David <david@...idv.dev>
To: Andrew Lunn <andrew@...n.ch>
Cc: Jonathan Corbet <corbet@....net>, "David S. Miller"
 <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Paul E. McKenney" <paulmck@...nel.org>, Randy Dunlap
 <rdunlap@...radead.org>, Xiongwei Song <xiongwei.song@...driver.com>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH] net: make driver settling time configurable

On 2/5/24 15:06, Andrew Lunn wrote:
> On Mon, Feb 05, 2024 at 12:44:40PM +0100, David Ventura wrote:
>> During IP auto configuration, some drivers apparently need to wait a
>> certain length of time to settle; as this is not true for all drivers,
>> make this length of time configurable.
> Do you see this problem with multiple drivers, or just one in
> particular. To me this seems like a driver bug, and you are just
> papering over the cracks.
>
> 	Andrew
I don't know of any drivers that may need to wait -- I noticed
this code path being hit when building a minimal kernel that only
had a virtio network device.
At least for the virtio device, the wait is unnecessary and bloats
the time to boot a minimal kernel from 15ms to 33ms.

     David