netdev - RE: [Intel-wired-lan] [PATCH iwl-next v5] ixgbe: Convert ret val type from s32 to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 17:44:38 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Keller, Jacob E" <jacob.e.keller@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	Simon Horman <horms@...nel.org>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v5] ixgbe: Convert ret val type
 from s32 to int

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jedrzej Jagielski
> Sent: Wednesday, January 31, 2024 4:34 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Keller, Jacob E <jacob.e.keller@...el.com>; netdev@...r.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Jagielski, Jedrzej <jedrzej.jagielski@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v5] ixgbe: Convert ret val type from s32 to int
>
> Currently big amount of the functions returning standard error codes
> are of type s32. Convert them to regular ints as typdefs here are not
> necessary to return standard error codes.
>
> Fix incorrect args alignment in touched functions.
>
> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  16 +-
>  .../net/ethernet/intel/ixgbe/ixgbe_82598.c    |  64 ++---
>  .../net/ethernet/intel/ixgbe/ixgbe_82599.c    | 124 ++++----
>  .../net/ethernet/intel/ixgbe/ixgbe_common.c   | 226 +++++++--------
>  .../net/ethernet/intel/ixgbe/ixgbe_common.h   | 112 ++++----
>  drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.c  |  12 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.h  |  10 +-
>  .../ethernet/intel/ixgbe/ixgbe_dcb_82598.c    |  26 +-
>  .../ethernet/intel/ixgbe/ixgbe_dcb_82598.h    |  30 +-
>  .../ethernet/intel/ixgbe/ixgbe_dcb_82599.c    |  12 +-
>  .../ethernet/intel/ixgbe/ixgbe_dcb_82599.h    |  35 +--
>  .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  |  10 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   4 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c  |  46 +--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h  |  10 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  | 180 ++++++------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h  |  52 ++--
>  .../net/ethernet/intel/ixgbe/ixgbe_sriov.c    |   8 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 186 ++++++------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c |  62 ++--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x540.h |  18 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 270 +++++++++---------
>  22 files changed, 744 insertions(+), 769 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)