netdev - RE: [Intel-wired-lan] [PATCH iwl-next v5 3/3] ixgbe: Clarify the values of the returning status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 17:51:09 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, Simon Horman <horms@...nel.org>, Dan Carpenter
	<dan.carpenter@...aro.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v5 3/3] ixgbe: Clarify the
 values of the returning status

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jedrzej Jagielski
> Sent: Wednesday, January 31, 2024 4:34 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Jagielski, Jedrzej <jedrzej.jagielski@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Dan Carpenter <dan.carpenter@...aro.org>
> Subject: [Intel-wired-lan] [PATCH iwl-next v5 3/3] ixgbe: Clarify the values of the returning status
>
> Converting s32 functions to regular int in the previous patch of the series
> caused triggering smatch warnings about missing error code.
>
> New smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status'
>
> Old smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
>
> Fix it by clearly stating returning error code as 0.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202401041701.6QKTsZmx-lkp@intel.com/
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)