netdev - Re: [net-next 0/3] Per epoll context busy poll support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240205114821.4601ea5b@kernel.org>
Date: Mon, 5 Feb 2024 11:48:21 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: Stanislav Fomichev <sdf@...gle.com>, sridhar.samudrala@...el.com, Eric
 Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, chuck.lever@...cle.com, jlayton@...nel.org,
 linux-api@...r.kernel.org, brauner@...nel.org, davem@...emloft.net,
 alexander.duyck@...il.com, Wei Wang <weiwan@...gle.com>, Amritha Nambiar
 <amritha.nambiar@...el.com>
Subject: Re: [net-next 0/3] Per epoll context busy poll support

On Mon, 5 Feb 2024 10:52:18 -0800 Joe Damato wrote:
> > Should we also add prefer_busy_poll parameter to EPIOCSPARAMS?
> > napi_busy_loop in ep_busy_loop has its prefer_busy_poll argument
> > hard-coded as false.  

Good catch! We only plumbed it thru to socket read busy poll.

> I think making this configurable is a good idea. I can add that in the v6
> in addition to fixing the incorrect commit message in patch 1/3.
> 
> What do you think, Jakub?

SGTM (with the caveat that I'm not epoll expert)