netdev - Re: [PATCH] ifstat.c: fix type incompatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFoKQtycQJd-fgosPBoXeJN8Crd31U8-kG5QHOz4KHe+5o1mTA@mail.gmail.com>
Date: Tue, 6 Feb 2024 09:26:29 -0500
From: Stephen Gallagher <sgallagh@...hat.com>
To: netdev@...r.kernel.org
Subject: Re: [PATCH] ifstat.c: fix type incompatibility

Please disregard; I titled this wrong. Please see "[PATCH] iproute2:
fix type incompatibility in ifstat.c" instead.

On Tue, Feb 6, 2024 at 9:20 AM Stephen Gallagher <sgallagh@...hat.com> wrote:
>
> Throughout ifstat.c, ifstat_ent.val is accessed as a long long unsigned
> type, however it is defined as __u64. This works by coincidence on many
> systems, however on ppc64le, __u64 is a long unsigned.
>
> This patch makes the type definition consistent with all of the places
> where it is accessed.
>
> Signed-off-by: Stephen Gallagher <sgallagh@...hat.com>
> ---
>  misc/ifstat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/misc/ifstat.c b/misc/ifstat.c
> index 721f4914..767cedd4 100644
> --- a/misc/ifstat.c
> +++ b/misc/ifstat.c
> @@ -58,7 +58,7 @@ struct ifstat_ent {
>         struct ifstat_ent       *next;
>         char                    *name;
>         int                     ifindex;
> -       __u64                   val[MAXS];
> +       unsigned long long      val[MAXS];
>         double                  rate[MAXS];
>         __u32                   ival[MAXS];
>  };
> --
> 2.43.0
>