netdev - Re: pull request: bluetooth 2024-02-02

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a94e0e2579028761fd1829ed5ad7e9daa87d9db.camel@redhat.com>
Date: Tue, 06 Feb 2024 16:46:50 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, linux-bluetooth@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: pull request: bluetooth 2024-02-02

On Tue, 2024-02-06 at 10:32 -0500, Luiz Augusto von Dentz wrote:
> Hi Paolo,
> 
> On Tue, Feb 6, 2024 at 10:21 AM Paolo Abeni <pabeni@...hat.com> wrote:
> > 
> > On Tue, 2024-02-06 at 09:45 -0500, Luiz Augusto von Dentz wrote:
> > > On Tue, Feb 6, 2024 at 9:33 AM Paolo Abeni <pabeni@...hat.com> wrote:
> > > > On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote:
> > > > > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858:
> > > > > 
> > > > >   netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800)
> > > > > 
> > > > > are available in the Git repository at:
> > > > > 
> > > > >   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02
> > > > > 
> > > > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3:
> > > > > 
> > > > >   Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500)
> > > > > 
> > > > > ----------------------------------------------------------------
> > > > > bluetooth pull request for net:
> > > > 
> > > > A couple of commits have some issue in the tag area (spaces between
> > > > Fixes and other tag):
> > > > > 
> > > > >  - btintel: Fix null ptr deref in btintel_read_version
> > > > >  - mgmt: Fix limited discoverable off timeout
> > > > >  - hci_qca: Set BDA quirk bit if fwnode exists in DT
> > > > 
> > > > this one ^^^
> > > > 
> > > > >  - hci_bcm4377: do not mark valid bd_addr as invalid
> > > > >  - hci_sync: Check the correct flag before starting a scan
> > > > >  - Enforce validation on max value of connection interval
> > > > 
> > > > and this one ^^^
> > > 
> > > Ok, do you use any tools to capture these? checkpatch at least didn't
> > > capture anything for me.
> > 
> > We use the nipa tools:
> > 
> > https://github.com/linux-netdev/nipa
> > 
> > specifically:
> > 
> > https://github.com/linux-netdev/nipa/blob/main/tests/patch/verify_fixes/verify_fixes.sh
> > 
> > (it can run standalone)
> 
> verify_fixes.sh HEAD^..HEAD
> verify_fixes.sh: line 201: $DESC_FD: ambiguous redirect
> 
> Not really sure where DESC_FD comes from, perhaps it needs to be set
> in the environment, anyway can you send the output it is generating?

I usually do:

export DESC_FD=1
verify_fixes.sh HEAD^..HEAD

Cheers,

Paolo