netdev - Re: [PATCH] iproute2: fix type incompatibility in ifstat.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcJbjmOKMNiNo5LE@renaissance-vector>
Date: Tue, 6 Feb 2024 17:17:18 +0100
From: Andrea Claudi <aclaudi@...hat.com>
To: Stephen Gallagher <sgallagh@...hat.com>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org, dsahern@...nel.org
Subject: Re: [PATCH] iproute2: fix type incompatibility in ifstat.c

On Tue, Feb 06, 2024 at 09:22:06AM -0500, Stephen Gallagher wrote:
> Throughout ifstat.c, ifstat_ent.val is accessed as a long long unsigned
> type, however it is defined as __u64. This works by coincidence on many
> systems, however on ppc64le, __u64 is a long unsigned.
> 
> This patch makes the type definition consistent with all of the places
> where it is accessed.
> 
> Signed-off-by: Stephen Gallagher <sgallagh@...hat.com>
> ---
>  misc/ifstat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/misc/ifstat.c b/misc/ifstat.c
> index 721f4914..767cedd4 100644
> --- a/misc/ifstat.c
> +++ b/misc/ifstat.c
> @@ -58,7 +58,7 @@ struct ifstat_ent {
>  	struct ifstat_ent	*next;
>  	char			*name;
>  	int			ifindex;
> -	__u64			val[MAXS];
> +	unsigned long long	val[MAXS];
>  	double			rate[MAXS];
>  	__u32			ival[MAXS];
>  };
> -- 
> 2.43.0
> 

Hi Stephen, thanks for taking care of this.

FYI, patch directed to iproute2 or iproute2-next tree should:
- preferrably have [PATCH iproute2] in their subject
- be directed or cc'd to iproute2 maintainers Stephen Hemminger and
  David Ahern, and to the author of the fixed commit if possible.

This should include a Fixes: line on the commit changing val to __u64:
Fixes: 5a52102b7c8f ("ifstat: Add extended statistics to ifstat")
Stephen, David: do Stephen needs to resend this?

That said, patch looks good to me, so feel free to add my reviewed-by to
the following versions of this patch.

Reviewed-by: Andrea Claudi <aclaudi@...hat.com>