netdev - Re: [net-next PATCH v6 05/10] dt-bindings: net: Document Qcom QCA807x PHY package

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65c2649a.1c0a0220.ca891.c8da@mx.google.com>
Date: Tue, 6 Feb 2024 17:55:49 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Robert Marko <robert.marko@...tura.hr>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [net-next PATCH v6 05/10] dt-bindings: net: Document Qcom
 QCA807x PHY package

On Tue, Feb 06, 2024 at 04:32:29PM +0000, Conor Dooley wrote:
> Hey Christian,
> 
> On Mon, Feb 05, 2024 at 05:48:37PM +0100, Christian Marangi wrote:
> > Document Qcom QCA807x PHY package.
> > 
> > Qualcomm QCA807X Ethernet PHY is PHY package of 2 or 5
> > IEEE 802.3 clause 22 compliant 10BASE-Te, 100BASE-TX and
> > 1000BASE-T PHY-s.
> > 
> > Document the required property to make the PHY package correctly
> > configure and work.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> 
> I think this looks pretty decent, some minor comments.
> 
> > +  qcom,package-mode:
> > +    description: |
> > +      PHY package can be configured in 3 mode following this table:
> > +
> > +                    First Serdes mode       Second Serdes mode
> > +      Option 1      PSGMII for copper       Disabled
> > +                    ports 0-4
> > +      Option 2      PSGMII for copper       1000BASE-X / 100BASE-FX
> > +                    ports 0-4
> > +      Option 3      QSGMII for copper       SGMII for
> > +                    ports 0-3               copper port 4
> > +
> > +      PSGMII mode (option 1 or 2) is configured dynamically by the driver
> 
> I'd drop mention of the driver here, with s/by the driver//.
>

Sure.

> > +      based on the presence of a connected SFP device.
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    enum:
> > +      - qsgmii
> > +      - psgmii
> > +    default: psgmii
> > +
> > +  qcom,tx-driver-strength-milliwatt:
> 
> Is this a typo? Should not it be "drive-strength"? There's 39 mentions
> in tree of "driver-strength" and 3500 for "drive-strength".

In the PHY datasheet the reg is called TX_DRIVER and the description say
TX driver amplitude adjustment.

But the section is PSGMII/QSGMII drive control 1 register...

Guess it's a typo in the datasheet. Will change to drive.

> 
> Otherwise I think the review comments have been resolved:
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> 

Thanks!

-- 
	Ansuel