netdev - RE: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <BY3PR18MB470744E7FFCCC1B38A0B4E8AA0462@BY3PR18MB4707.namprd18.prod.outlook.com>
Date: Tue, 6 Feb 2024 18:29:52 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@...vell.com>
Subject: RE: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe

> -----Original Message-----
> From: Sai Krishna Gajula
> Sent: Monday, January 29, 2024 3:21 PM
> To: Jakub Kicinski <kuba@...nel.org>
> Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@...vell.com>; Geethasowjanya Akula
> <gakula@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
> Subject: Re: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe
> 
> 
> > -----Original Message-----
> > From: Jakub Kicinski <kuba@...nel.org>
> > Sent: Friday, January 26, 2024 6:58 AM
> > To: Sai Krishna Gajula <saikrishnag@...vell.com>
> > Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
> > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Sunil Kovvuri
> > Goutham <sgoutham@...vell.com>; Geethasowjanya Akula
> > <gakula@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>;
> Subbaraya
> > Sundeep Bhatta <sbhatta@...vell.com>
> > Subject: Re: [net-next PATCH] octeontx2-pf: Reset MAC stats during
> > probe
> >
> > On Thu, 25 Jan 2024 16:36:01 +0530 Sai Krishna wrote:
> > > Reset CGX/RPM MAC HW statistics at the time of driver probe()
> > >
> > > Also added a devlink option to do the same at runtime, this will be
> > > helpful during debug.
> > >
> > > Usage: Reset MAC stats
> > > devlink dev param  set  pci/0002:03:00.0 name mac_stats_reset value
> > > true cmode runtime
> >
> > Where are the stats reported? It'd be more intuitive to add the
> > ability to reset stats to whatever interface is used to report them.
> > Or one of your reset interfaces (devlink dev reload).
> 
> We are using debugfs interface to report the stats. As you had indicated
> previously not to take input to debugfs, we implemented devlink interface to
> reset the MAC stats.

If you recommend us to implement the reset MAC stats using debugfs instead of devlink, we will implement the same and submit patch V2, please suggest.

Thanks,
Sai