netdev - Re: [RFC] perf: Reconsider an error code selection in bpf_map_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7ciHGv9s92Yz4VuFUhuN9HCHe=Bq7dMD_XSBTkg1+tYw+w@mail.gmail.com>
Date: Mon, 5 Feb 2024 18:12:50 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-perf-users@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	Adrian Hunter <adrian.hunter@...el.com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Alexei Starovoitov <ast@...nel.org>, 
	Andrii Nakryiko <andrii@...nel.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, Christy Lee <christylee@...com>, 
	Daniel Borkmann <daniel@...earbox.net>, Ian Rogers <irogers@...gle.com>, 
	Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...nel.org>, 
	John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Martin KaFai Lau <kafai@...com>, 
	Peter Zijlstra <peterz@...radead.org>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, 
	YueHaibing <yuehaibing@...wei.com>, bpf@...r.kernel.org, netdev@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] perf: Reconsider an error code selection in bpf_map__fprintf()

Hello,

On Thu, Feb 1, 2024 at 10:49 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> > A null pointer check is performed for the input parameter “map”.
> > It looks suspicious that the function “PTR_ERR” is applied then for
> > a corresponding return statement.
>
> Are contributions also by YueHaibing still waiting on further development considerations?
>
> [PATCH -next] perf: Fix pass 0 to PTR_ERR
> https://lore.kernel.org/lkml/20220611040719.8160-1-yuehaibing@huawei.com/
> https://lkml.org/lkml/2022/6/11/3

I think we dropped the bpf-loader and it seems bpf_map.[ch] is
leftover.  I don't see any users of bpf_map__fprintf() in the tree.
Maybe we can drop it too.

Thanks,
Namhyung