netdev - Re: [PATCH net-next v2] eth: mlx5: link NAPI instances to queues and IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87jznikwe9.fsf@nvidia.com>
Date: Mon, 05 Feb 2024 21:09:19 -0800
From: Rahul Rameshbabu <rrameshbabu@...dia.com>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc: Joe Damato <jdamato@...tly.com>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, tariqt@...dia.com, Saeed Mahameed
 <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "open list:MELLANOX
 MLX5 core VPI driver" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH net-next v2] eth: mlx5: link NAPI instances to queues
 and IRQs

On Mon, 05 Feb, 2024 18:52:45 -0800 Rahul Rameshbabu <rrameshbabu@...dia.com> wrote:
> On Tue, 06 Feb, 2024 02:49:56 +0000 Joe Damato <jdamato@...tly.com> wrote:
>> Make mlx5 compatible with the newly added netlink queue GET APIs.
>>
>> v1 -> v2:
>>   - Move netlink NULL code to mlx5e_deactivate_channel
>>   - Move netif_napi_set_irq to mlx5e_open_channel and avoid storing the
>>     irq, after netif_napi_add which itself sets the IRQ to -1.
>>   - Fix white space where IRQ is stored in mlx5e_open_channel

Also, the changelog should not be part of the commit description since
it will not make much sense once the final version is accepted. You can
either manually paste the changelog in a section of the patch that will
not be applied by git or use git notes to annotate the changelog.

    * https://git-scm.com/docs/git-notes
    * https://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt---notesltrefgt

>>
>> Signed-off-by: Joe Damato <jdamato@...tly.com>
>> ---

--
Thanks,

Rahul Rameshbabu