netdev - Re: stmmac on Banana PI CPU stalls since Linux 6.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240206092351.59b10030@meshulam.tesarici.cz>
Date: Tue, 6 Feb 2024 09:23:51 +0100
From: Petr Tesařík <petr@...arici.cz>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: Marc Haber <mh+netdev@...schlus.de>, Andrew Lunn <andrew@...n.ch>,
 alexandre.torgue@...s.st.com, Jose Abreu <joabreu@...opsys.com>, Chen-Yu
 Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel
 Holland <samuel@...lland.org>, Jisheng Zhang <jszhang@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: stmmac on Banana PI CPU stalls since Linux 6.6

Hi Florian,

On Mon, 5 Feb 2024 13:50:35 -0800
Florian Fainelli <f.fainelli@...il.com> wrote:

> On 2/5/24 12:12, Marc Haber wrote:
> > On Fri, Jan 26, 2024 at 12:10:28PM +0100, Petr Tesařík wrote:  
> >> Then you may want to start by verifying that it is indeed the same
> >> issue. Try the linked patch.  
> > 
> > The linked patch seemed to help for 6.7.2, the test machine ran for five
> > days without problems. After going to unpatched 6.7.2, the issue was
> > back in six hours.  
> 
> Do you mind responding to Petr's patch with a Tested-by? Thanks!

I believe Marc tested my first attempt at a solution (the one with
spinlocks), not the latest incarnation. FWIW I have tested a similar
scenario, with similar results.

@Marc: I was able to reduce the time until hang by running a "ping -f"
from another machine on the same LAN and running "ethtool -S" in a
tight loop on the system under testing (over an SSH connection, so it
probably contributed substantially to the network traffic). The
unpatched kernel froze within a few minutes.

Petr T