netdev - Re: [PATCH v3 net-next 00/15] net: more factorization in cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ee7f0562ae3c646c4c362c5e1ed19f31e0f8dd4.camel@redhat.com>
Date: Tue, 06 Feb 2024 10:15:28 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>
Cc: Antoine Tenart <atenart@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 00/15]  net: more factorization in
 cleanup_net() paths

On Mon, 2024-02-05 at 12:47 +0000, Eric Dumazet wrote:
> This series is inspired by recent syzbot reports hinting to RTNL and
> workqueue abuses.
> 
> rtnl_lock() is unfair to (single threaded) cleanup_net(), because
> many threads can cause contention on it.
> 
> This series adds a new (struct pernet_operations) method,
> so that cleanup_net() can hold RTNL longer once it finally
> acquires it.
> 
> It also factorizes unregister_netdevice_many(), to further
> reduce stalls in cleanup_net().
> 
> v3: Dropped "net: convert default_device_exit_batch() to exit_batch_rtnl method"
>     Jakub (and KASAN) reported issues with bridge, but the root cause was with this patch.
>     default_device_exit_batch() is the catch-all method, it includes "lo" device dismantle.
> 

I *think* this still causes KASAN splat in the CI WRT vxlan devices,
e.g.:

https://netdev-3.bots.linux.dev/vmksft-net/results/453141/17-udpgro-fwd-sh/stdout

(at least this series is the most eye catching thing that landed into
the relevant batch)

Cheers,

Paolo