netdev - Re: [PATCH] net: ieee802154: at86rf230: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240206102503.760ecb64@xps-13>
Date: Tue, 6 Feb 2024 10:25:03 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Alexander Aring <aahringo@...hat.com>
Cc: Bo Liu <liubo03@...pur.com>, alex.aring@...il.com,
 stefan@...enfreihafen.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, linux-wpan@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ieee802154: at86rf230: convert to use maple tree
 register cache

Hi,

aahringo@...hat.com wrote on Mon, 5 Feb 2024 14:42:09 -0500:

> Hi,
> 
> On Fri, Feb 2, 2024 at 2:56 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> >
> > Hi Bo,
> >
> > liubo03@...pur.com wrote on Fri, 2 Feb 2024 01:45:12 -0500:
> >  
> > > The maple tree register cache is based on a much more modern data structure
> > > than the rbtree cache and makes optimisation choices which are probably
> > > more appropriate for modern systems than those made by the rbtree cache.  
> >
> > What are the real intended benefits? Shall we expect any drawbacks?
> >  
> 
> I doubt it has really any benefits, only the slowpath is using regmap
> to set some registers. Maybe if you change phy setting frequently it
> might have an impact, but this isn't even a path considered to run
> fast.

Ok, thanks Alex for the info; in this case I'm fine:

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,
Miquèl