netdev - Re: [PATCH net-next v7 2/2] net: add netmem to skb_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1560533cb4eb3f36e640c9931fba93e0d0378652.camel@redhat.com>
Date: Tue, 06 Feb 2024 10:30:14 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Mina Almasry <almasrymina@...gle.com>, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>, Jason Gunthorpe
 <jgg@...dia.com>, Christian König
 <christian.koenig@....com>, Shakeel Butt <shakeelb@...gle.com>, Yunsheng
 Lin <linyunsheng@...wei.com>, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next v7 2/2] net: add netmem to skb_frag_t

On Thu, 2024-02-01 at 13:34 -0800, Mina Almasry wrote:
> @@ -2528,8 +2562,25 @@ static inline void skb_fill_page_desc_noacc(struct sk_buff *skb, int i,
>  	shinfo->nr_frags = i + 1;
>  }
>  
> -void skb_add_rx_frag(struct sk_buff *skb, int i, struct page *page, int off,
> -		     int size, unsigned int truesize);
> +static inline void skb_add_rx_frag_netmem(struct sk_buff *skb, int i,
> +					  netmem_ref netmem, int off, int size,
> +					  unsigned int truesize)
> +{
> +	DEBUG_NET_WARN_ON_ONCE(size > truesize);
> +
> +	skb_fill_netmem_desc(skb, i, netmem, off, size);
> +	skb->len += size;
> +	skb->data_len += size;
> +	skb->truesize += truesize;
> +}

> +
> +static inline void skb_add_rx_frag(struct sk_buff *skb, int i,
> +				   struct page *page, int off, int size,
> +				   unsigned int truesize)
> +{
> +	skb_add_rx_frag_netmem(skb, i, page_to_netmem(page), off, size,
> +			       truesize);
> +}

I'm very sorry, I was not clear in my previous feedback: only
skb_add_rx_frag() was supposed to be 'static inline'.

skb_add_rx_frag_netmem() contains a few more instructions and there are
a lot of callers, always inline it does not look the best option.

I'm sorry for requiring an additional iteration, but feel free to ad my
Acked-by with the above change.

Cheers,

Paolo