netdev - Re: [PATCH][next] netxen_nic: remove redundant assignment to variable capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240207094609.GN1104779@kernel.org>
Date: Wed, 7 Feb 2024 09:46:09 +0000
From: Simon Horman <horms@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Manish Chopra <manishc@...vell.com>, Rahul Verma <rahulv@...vell.com>,
	GR-Linux-NIC-Dev@...vell.com,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] netxen_nic: remove redundant assignment to
 variable capability

On Tue, Feb 06, 2024 at 11:50:49AM +0000, Colin Ian King wrote:
> The variable capability is being assigned a value that is never
> read and is being re-assigned later. The assignment is redundant and
> can be removed. Also remove empty line before assignment to capability.
> 
> Cleans up clang scan build warning:
> drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1189:2: warning:
> Value stored to 'capability' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> index 35ec9aab3dc7..51fa880eaf6c 100644
> --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> @@ -1186,7 +1186,6 @@ static int
>  netxen_p3_has_mn(struct netxen_adapter *adapter)
>  {
>  	u32 capability, flashed_ver;
> -	capability = 0;

This part looks correct :)

>  
>  	/* NX2031 always had MN */
>  	if (NX_IS_REVISION_P2(adapter->ahw.revision_id))
> @@ -1197,7 +1196,6 @@ netxen_p3_has_mn(struct netxen_adapter *adapter)
>  	flashed_ver = NETXEN_DECODE_VERSION(flashed_ver);
>  
>  	if (flashed_ver >= NETXEN_VERSION_CODE(4, 0, 220)) {
> -

This part doesn't seem strictly related to the patch description.
But in looking at it more closely, I wonder if it would be good
to reduce the scope of capability to this context (and leave the bank
line).

>  		capability = NXRD32(adapter, NX_PEG_TUNE_CAPABILITY);
>  		if (capability & NX_PEG_TUNE_MN_PRESENT)
>  			return 1;

In any case, I agree that this patch is correct, and I'm happy with
it with or without the change I suggested above.

Reviewed-by: Simon Horman <horms@...nel.org>