netdev - Re: [PATCH net v2] bonding: do not report NETDEV_XDP_ACT_XSK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87plx8vbpt.fsf@toke.dk>
Date: Wed, 07 Feb 2024 10:57:02 +0100
From: Toke Høiland-Jørgensen <toke@...hat.com>
To: Magnus Karlsson <magnus.karlsson@...il.com>, magnus.karlsson@...el.com,
 bjorn@...nel.org, ast@...nel.org, daniel@...earbox.net,
 netdev@...r.kernel.org, maciej.fijalkowski@...el.com, kuba@...nel.org,
 pabeni@...hat.com, davem@...emloft.net, j.vosburgh@...il.com,
 andy@...yhouse.net, hawk@...nel.org, john.fastabend@...il.com,
 edumazet@...gle.com, lorenzo@...nel.org
Cc: bpf@...r.kernel.org, Prashant Batra <prbatra.mail@...il.com>
Subject: Re: [PATCH net v2] bonding: do not report NETDEV_XDP_ACT_XSK_ZEROCOPY

Magnus Karlsson <magnus.karlsson@...il.com> writes:

> From: Magnus Karlsson <magnus.karlsson@...el.com>
>
> Do not report the XDP capability NETDEV_XDP_ACT_XSK_ZEROCOPY as the
> bonding driver does not support XDP and AF_XDP in zero-copy mode even
> if the real NIC drivers do.
>
> Note that the driver used to report everything as supported before a
> device was bonded. Instead of just masking out the zero-copy support
> from this, have the driver report that no XDP feature is supported
> until a real device is bonded. This seems to be more truthful as it is
> the real drivers that decide what XDP features are supported.
>
> Fixes: cb9e6e584d58 ("bonding: add xdp_features support")
> Reported-by: Prashant Batra <prbatra.mail@...il.com>
> Link: https://lore.kernel.org/all/CAJ8uoz2ieZCopgqTvQ9ZY6xQgTbujmC6XkMTamhp68O-h_-rLg@mail.gmail.com/T/
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>

Reviewed-by: Toke Høiland-Jørgensen <toke@...hat.com>